Skip to content

Update faslty dependency#7

Merged
aram356 merged 1 commit intomainfrom
feature/update-fastly-crate
Nov 3, 2025
Merged

Update faslty dependency#7
aram356 merged 1 commit intomainfrom
feature/update-fastly-crate

Conversation

@aram356
Copy link
Copy Markdown
Contributor

@aram356 aram356 commented Nov 3, 2025

No description provided.

@aram356 aram356 merged commit ec10ba4 into main Nov 3, 2025
2 checks passed
@aram356 aram356 deleted the feature/update-fastly-crate branch November 3, 2025 18:05
aram356 added a commit that referenced this pull request May 9, 2026
CodeQL's `rust/cleartext-logging` rule (alert #7) taints any value
returned by a function whose name contains "secret" — it can't tell
configuration metadata (the binding identifier from edgezero.toml)
from secret material. The previous rename
`secret_store_name → secret_store_binding` did NOT defeat the
heuristic because "secret" is still in the function name.

Real fix: stop logging the binding name. Operators can read their
own `edgezero.toml` to verify which store binding was configured.
The presence message ("secrets enabled for axum") is still emitted,
which is the only thing the log line was actually load-bearing for.

Updated the affected unit test assertion to match the new wording.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant